dragonfly-operator icon indicating copy to clipboard operation
dragonfly-operator copied to clipboard

fix(helm): update CRDs in chart

Open frivoire opened this issue 4 months ago • 4 comments

Why ?

After installing the operator with the latest version (1.2.1), we get an old CRD version, which lacks recent features (ex: the tiering block). And I'm guessing that this old version is not intended, and just a forgotten step during the release process. Thus this PR to update it.

Notes

This PR seems huge in term of lines added/modified/removed, but I did no real change. I only performed 2 steps:

cd ~/git/dragonfly-operator/

cp manifests/crd.yaml charts/dragonfly-operator/templates/crds.yaml
git add charts/dragonfly-operator/templates/crds.yaml
git ci -m "Copy simply CRD from manifests/ dir"

vim charts/dragonfly-operator/templates/crds.yaml
git add charts/dragonfly-operator/templates/crds.yaml
git ci -m "Reinclude the few helm wrapper lines (top & bottom of file)"

NB: also, don't hesitate to look at diff without whitespace (there has been changes in that area)

frivoire avatar Aug 25 '25 12:08 frivoire

Thanks @frivoire, yep, looks like we forgot to update this crd. LGTM, can you fix the conflict?

Abhra303 avatar Sep 30 '25 08:09 Abhra303

@frivoire a friendly ping :)

romange avatar Oct 01 '25 08:10 romange

I just recreated the git branch from scratch (using the same steps than given in the initial description) and force-pushed. So it should include all recent changes, and without any conflict of course.

frivoire avatar Oct 01 '25 09:10 frivoire

Can you please sign your commit?

Abhra303 avatar Oct 01 '25 13:10 Abhra303