dragonfly-operator icon indicating copy to clipboard operation
dragonfly-operator copied to clipboard

Configurable default image

Open foosinn opened this issue 1 year ago • 4 comments

Currently the default image for Dragonfly Instances is hardcoded (see 1).

For air-gapped setups it would be nice to replace the default value. Maybe configurable via command-line or enviornment?

Thanks!

foosinn avatar Jan 03 '25 09:01 foosinn

Hey @foosinn,

You can override the image in your Dragonfly configuration by setting the image argument accordignly.

https://github.com/dragonflydb/dragonfly-operator/blob/b07f733376e75f4a600345e538c27ff258502e6f/config/crd/bases/dragonflydb.io_dragonflies.yaml#L1193

Feel free to reopen the issue, if this does not solve your problem.

Pothulapati avatar Jan 08 '25 08:01 Pothulapati

They @Pothulapati,

thanks for your quick reply.

In our case we would like to set a default while installing the operator. So developers can create their dragonflydb without having to have knowledge about our internal images.

I'm aware that this is potentially out of scope and we also can solve this by wrapping it into a helm chart with some defaults. Please let me know :)

foosinn avatar Jan 08 '25 09:01 foosinn

Could this be re-opened? We have a bunch of different teams and projects using dragonfly instances, and when there is a fix in a specific dragonfly version we either have to wait until the dragonfly operator changes the default image, or override the image in all of the various places. Having this be configurable (even via an env or configmap?) for the operator would make operations a lot better.

alphabet5 avatar Mar 06 '25 17:03 alphabet5

Ahh, That makes sense actually!

Pothulapati avatar Mar 07 '25 05:03 Pothulapati