dragonfly-operator icon indicating copy to clipboard operation
dragonfly-operator copied to clipboard

Add `imagePullSecrets` support for Custom Resources

Open jurim76 opened this issue 1 year ago • 7 comments

CRD supports image value only with predefined external registry. Sometimes access to registry is restricted to internal registry only, in this case you need to define imagePullSecrets or modify serviceAccount.

jurim76 avatar Jun 06 '24 19:06 jurim76

@jurim76 Can you provide more details? I'd like to help on this one

Aym3nTN avatar Jul 05 '24 08:07 Aym3nTN

CR should support imagePullSecrets directive

For example Define in CR yaml

image: "some.local.repo/dragonfly:v1.20.1"
imagePullSecrets:
  - name: regcred

The image will be pulled from some.local.repo, using "regcred" secret

jurim76 avatar Jul 12 '24 11:07 jurim76

hi @Aym3nTN any ETA?

artsenko-cyco avatar Jul 23 '24 14:07 artsenko-cyco

I am also currently blocked by this, unable to even deploy an instance in my cluster since images from public repositories are not allowed...

@Aym3nTN Can I provide any assistance on this? Are you still working on it?

mircea-pavel-anton avatar Sep 12 '24 08:09 mircea-pavel-anton

@mircea-pavel-anton I hadn't make significant progress. Feel free to work on it.

Aym3nTN avatar Sep 12 '24 10:09 Aym3nTN

I'll see if I can get something going sometime later next week!

mircea-pavel-anton avatar Sep 12 '24 16:09 mircea-pavel-anton

After @jurim76 PR, it seems like the imagePullSecrets was being added here: https://raw.githubusercontent.com/dragonflydb/dragonfly-operator/main/manifests/dragonfly-operator.yaml, but it is missing in the latest release (e.g. dragonfly-operator-v1.1.10.tgz).

starek4 avatar Mar 13 '25 10:03 starek4