dragome-sdk

dragome-sdk copied to clipboard

StringBuilder is very slow

6

For string concatenation which is faster with Dragome? StringBuilder does not seem to be fast. It uses array and uses array push for append. Is concat method of String faster?...

neuronsupport

Missing annotation methods

2

getDeclaredAnnotation and getDeclaredAnnotations are missing in some class like Class, Field and Method. Also must check they are correctly because getAnnotation is different from getDeclaredAnnotation.

xpenatan

xpenatan

For some reason, delegator class is not passing node in parameter.  You can reproduce with the uncommented code: https://github.com/xpenatan/gdx-dragome-backend/blob/261394c944f874935ae50a382f70d67bc4532084/backends/gdx-backend-dragome/src/com/badlogic/gdx/backends/dragome/DragomeGraphics.java#L86-L92 Could it be because parameter type is a Object ?

xpenatan

Compilation process too slow on certain situations

1

@nicolaichuk: please report your compilation problem here. We need to reproduce this in a controlled small environment to be able to fix it. May be if you debug compilation process...

fpetrola

NPE in com.dragome.compiler.parser.Pass1.selectForm(InstructionType instructionType)

1

NullPointerEception in https://github.com/dragome/dragome-sdk/blob/master/dragome-bytecode-js-compiler/src/main/java/com/dragome/compiler/parser/Pass1.java#L821 stack.size = 2 j = 2 stack.peek(j) = null this exception silence in this line https://github.com/dragome/dragome-sdk/blob/master/dragome-bytecode-js-compiler/src/main/java/com/dragome/compiler/parser/Parser.java#L465 @fpetrola, Is it good? How i can enable isFailOnError from config?

nicolaichuk

fpetrola

Use standard java logging mechanism

8

@fpetrola, Why you write own [com.dragome.compiler.utils.Log](https://github.com/dragome/dragome-sdk/blob/master/dragome-bytecode-js-compiler/src/main/java/com/dragome/compiler/utils/Log.java) instead of using standard java.util.logging.Logger?

nicolaichuk

Collect in log all information need for build environment reproduce

2

Collect in log minimal and sufficient information need for build environment reproduce. To be able to copy it into a description of the any bug.

nicolaichuk

Add implementations for: ### Class - [ ] java.lang.Class.getAnnotatedInterfaces() - [ ] java.lang.Class.getAnnotatedSuperclass() - [x] java.lang.Class.getAnnotation(Class) - [ ] java.lang.Class.getAnnotations() - [ ] java.lang.Class.getAnnotationsByType(Class) - [ ] java.lang.Class.getDeclaredAnnotation(Class) - [...

fpetrola