missing-container-metrics icon indicating copy to clipboard operation
missing-container-metrics copied to clipboard

Add toleration to run on all nodes (even tainted ones)

Open dshackith opened this issue 3 years ago • 5 comments

We segment our node groups with taints, and by default missing-container-metrics does not install on any nodes with taints. Adding the toleration

tolerations:
        - operator: Exists

Would ensure the daemonset is running on all nodes. Alternatively, allowing for setting tolerations in the Helm chart would give deployers the ability to manage this.

dshackith avatar Apr 08 '21 12:04 dshackith

thank you for the tip! Will release soon(ish) a helm chart version that will allow to set tolerations.

draganm avatar Apr 29 '21 22:04 draganm

Hi, I'm potentially interested in contributing to the helm chart, what's the repo for contributing to it? Found the helm chart but that links to this repo that doesn't have a helm chart. Thanks!

anderson4u2 avatar May 12 '21 19:05 anderson4u2

Please add tolerations support to the helm chart.

wiseelf avatar Jul 05 '21 04:07 wiseelf

Created https://github.com/draganm/missing-container-metrics/pull/9 for to add tolerations for all taints

dshackith avatar Jul 13 '21 18:07 dshackith

Hi, I'm potentially interested in contributing to the helm chart, what's the repo for contributing to it? Found the helm chart but that links to this repo that doesn't have a helm chart. Thanks!

@anderson4u2 The chart is in the docs subdir: https://github.com/draganm/missing-container-metrics/tree/master/docs/missing-container-metrics

dshackith avatar Jul 13 '21 18:07 dshackith