rescript-storybook icon indicating copy to clipboard operation
rescript-storybook copied to clipboard

Examples are not idiomatic?

Open rolandpeelen opened this issue 2 years ago • 0 comments

Hey!

I see the examples go like this:

open BsStorybook.Story;

let _module = [%bs.raw "module"];

storiesOf("My First Reason Story", _module)
->add("Chapter I", () => <span> {React.string("Hello rescript-storybook!")} </span>);

But afaik - prefixing something with an underscore tells the compiler it should be ignored. I think the idiomatic way is to postfix it with an underscore, no? module_ instead of _module ?

Completely low-prio issue / nit. But happy to create a PR for this :)

rolandpeelen avatar Nov 16 '22 14:11 rolandpeelen