dracut icon indicating copy to clipboard operation
dracut copied to clipboard

refactor(nfs): remove leftover code

Open aafeijoo-suse opened this issue 1 year ago • 4 comments

  • Leftover greps used when chown was perfomed after them.
  • $initdir/var/lib/rpcbind already created with mkdir -m 0770, it is not necessary to chmod 770 again.

Follow-up to 5ebf48d2baa7d7cbad7cfc663319f8ca80f76398

Checklist

  • [X] I have tested it locally
  • [ ] I have reviewed and updated any documentation if relevant
  • [ ] I am providing new code and test(s) for it

aafeijoo-suse avatar Dec 01 '23 11:12 aafeijoo-suse

I am not aware of a standard that would require nfs user. Different distributions use different usernames, which is why testing the username is useful.

Better solution would be to determine the username instead of dracut hardcoding it.

https://github.com/dracutdevs/dracut/issues/2259

LaszloGombos avatar Jan 15 '24 04:01 LaszloGombos

I am not aware of a standard that would require nfs user. Different distributions use different usernames, which is why testing the username is useful.

Better solution would be to determine the username instead of dracut hardcoding it.

This comment is unrelated to what this PR is about.

aafeijoo-suse avatar Jan 15 '24 07:01 aafeijoo-suse

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Mar 13 '24 06:03 stale[bot]

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Apr 22 '24 06:04 stale[bot]