dracut icon indicating copy to clipboard operation
dracut copied to clipboard

fix(rootfs-block): install mount hook with lower priority

Open LaszloGombos opened this issue 1 year ago • 2 comments

Priority 99 should be reserved for hooks that need to run last.

rootfs-block mount hook does not need to run last, rather it is expected to run early on during the mount stage.

Lower the priority of the rootfs-block mount hook to make it easier to schedule mount hooks before and after.

This change will make better use 00-99 priority space.

This pull request changes...

Changes

Checklist

  • [X] I have tested it locally
  • [ ] I have reviewed and updated any documentation if relevant
  • [ ] I am providing new code and test(s) for it

Fixes #

LaszloGombos avatar Aug 22 '22 18:08 LaszloGombos

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Sep 22 '22 00:09 stale[bot]

not stale

LaszloGombos avatar Sep 22 '22 12:09 LaszloGombos

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Oct 22 '22 17:10 stale[bot]

This is part of a larger effort to try to leave some namespace empty (e.g. 0-9, 90-99), so that users of dracut (other projects, distro's, end-users) can fully take advantage of dracut's modular infrastructure (e.g. with out of tree modules or dracut command line arguments).

LaszloGombos avatar Oct 23 '22 12:10 LaszloGombos

You need to be a bit more spesific about your larger effort since 90-99 range is intended for the stuff that dracut relies on.

johannbg avatar Oct 23 '22 12:10 johannbg

90-99 range is intended for the stuff that dracut relies on

I am advocating to explore if we should change this rule to 80-89 (instead of 90-99) - also filed an issue for this larger discussion - https://github.com/dracutdevs/dracut/issues/2015 .

Regardless, this PR is not to make this larger change (which would need more discussion and perhaps also documentation changes).

This PR is scoped to discuss if rootfs-block really need to be 99 priority.

LaszloGombos avatar Oct 23 '22 12:10 LaszloGombos

Well you have not explained why priority 99 should be reserved for hooks that should be run last and I would say that rootfs-block really needs to be 99 priority or do you think it's not something that dracut needs to rely on anymore?

johannbg avatar Oct 23 '22 13:10 johannbg

Closing to take it out from active PR list, but plan to resume work at later time. Not targeting the upcoming release with these changes.

LaszloGombos avatar Oct 28 '22 02:10 LaszloGombos