dracut icon indicating copy to clipboard operation
dracut copied to clipboard

test: do not bring up the network interface if it is not needed

Open LaszloGombos opened this issue 1 year ago • 4 comments

Notice that TEST-04 does not bring up networking interface as it is not needed. Apply the same principle for all local tests that do not need networking.

This should make the tests run faster and slightly more reliable.

This change also brings us to a better place where network-legacy files are only gets included via proper dracut module inclusion.

  • [X] I have tested it locally
  • [X] I have reviewed and updated any documentation if relevant
  • [X] I am providing new code and test(s) for it

LaszloGombos avatar Aug 17 '22 04:08 LaszloGombos

If we dont need networking we should not need any network related tools ( such as ping ip etc, ) either so if we can we should probably drop those as well.

johannbg avatar Aug 18 '22 06:08 johannbg

if we can we should probably drop network related tools ( such as ping ip etc, ) as well.

Thanks for the review. It looks like we can indeed drop more tools. Updated the PR.

LaszloGombos avatar Aug 18 '22 13:08 LaszloGombos

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

stale[bot] avatar Sep 20 '22 16:09 stale[bot]

not stale

LaszloGombos avatar Sep 20 '22 16:09 LaszloGombos