dracut
dracut copied to clipboard
dracutdevs
ci: add Gentoo Linux container
Checklist
- [X] I have tested it locally
- [X] I have reviewed and updated any documentation if relevant
- [ ] I am providing new code and test(s) for it
@johannbg this PR is ready for review (from my perspective). Thank you !
@LaszloGombos you need to fix your manifest as can be seen in the failing test :smile:
Try include the full path in the FROM line in Dockerfile-Gentoo, for example instead of using FROM gentoo/portage:latest use FROM docker.io/gentoo/portage:latest
Btw is it better to use portage instead of the stage3 images for Gentoo?
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Try include the full path in the FROM line in Dockerfile-Gentoo,
Ok, updated the PR. Thanks for the hint !
Log of building the container to help with the reviews: https://github.com/dracutdevs/dracut/runs/7707115197 Also attached, as not sure about the retention policy log.txt .
CC @aafeijoo-suse to help with CI and/or move this PR forward somehow.
No config file for packit (e.g. .packit.yaml) found in dracutdevs/dracut on commit 94c51c1c950591b963128ce550e8f89f4b1a25a8
For more info, please check out the documentation or contact the Packit team.
![packit-as-a-service[bot] avatar](https://avatars.githubusercontent.com/in/29076?v=4 "Published by a pub.dev verified publisher"){kind=small}
I found this useful tool which allows to locally test these kind of github actions: https://github.com/nektos/act
Although the docker tags look good, it throws the same error:
# act -j nosystemd
[Integration Test/nosystemd] Cannot parse container options: --privileged -v /dev:/dev
[Integration Test/nosystemd] 🚀 Start image=ghcr.io/dracutdevs/gentoo:latest
[Integration Test/nosystemd] 🐳 docker pull image=ghcr.io/dracutdevs/gentoo:latest platform= username= forcePull=false
[Integration Test/nosystemd] 🏁 Job succeeded
Error: Error response from daemon: manifest unknown
@aafeijoo-suse Thanks for helping out.
Error: Error response from daemon: manifest unknown
Changes of Dockerfiles in this PR has no impact on integration tests, since containers are updated only on push events not on pull requests.
This is not a new problem and I have observed this in other PRs as well (e.g. https://github.com/dracutdevs/dracut/pull/1827). We had this problem for quite some time, and resolving this problem is outside of the scope of "introducing Gentoo container" PR.
Most importantly, after the PR lands and the container is pushed, subsequent CI runs and PRs would not have the test failing.
TBH, this kind of PRs are so rare, that I am not sure if we want to address resolving this race in the CI system - lot of complexity for little benefit.
One trivial work around is land the container code first and do the test integration PR later when the container is available - which is also the proposed approach on https://github.com/dracutdevs/dracut/pull/1827
I will update this PR and just introduce the Gentoo container. Hope this will also make the review easier as the PR will be smaller.
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.
Some dracut tests run and pass on this gentoo container. Unfortunately Github Actions struggles with this container - see https://github.com/actions/checkout/issues/334#issuecomment-716068696 . I plan to look into some workaround.