dracut-ng icon indicating copy to clipboard operation
dracut-ng copied to clipboard

chore!: drop support for ifcfg

Open LaszloGombos opened this issue 1 year ago • 7 comments

Changes

Checklist

  • [ ] I have tested it locally
  • [ ] I have reviewed and updated any documentation if relevant
  • [ ] I am providing new code and test(s) for it

Fixes #503

LaszloGombos avatar Jul 20 '24 00:07 LaszloGombos

CC @dtardon and @steffen-maier

LaszloGombos avatar Jul 20 '24 04:07 LaszloGombos

I believe this module is still used by Mageia, OpenMandriva, and SUSE at the moment, though I think at least OpenMandriva and SUSE are in the process of migrating to NetworkManager.

FYI @berolinux @dracut-ng/opensuse-maint

Conan-Kudo avatar Jul 20 '24 20:07 Conan-Kudo

The last OpenMandriva release that still uses ifcfg, 5.0, is about to go EOL. No problem from our side.

berolinux avatar Jul 20 '24 23:07 berolinux

SUSE uses (and will continue to use) 35network-legacy, but not 45ifcfg.

@aafeijoo-suse, correct me if I'm wrong.

mwilck avatar Aug 09 '24 10:08 mwilck

SUSE uses (and will continue to use) 35network-legacy, but not 45ifcfg.

@aafeijoo-suse, correct me if I'm wrong.

Yes, you're right.

aafeijoo-suse avatar Aug 09 '24 11:08 aafeijoo-suse

My understanding is that SUSE Framework One / SUSE Linux 16 platform will be using NetworkManager, but either way, we have confirmation that it isn't being used by SUSE platforms anymore.

Conan-Kudo avatar Aug 11 '24 06:08 Conan-Kudo

My understanding is that SUSE Framework One / SUSE Linux 16 platform will be using NetworkManager

I was talking about current SLE.

mwilck avatar Aug 12 '24 07:08 mwilck

@mwilck So you okay with us dropping this, or do you need it still?

Conan-Kudo avatar Aug 24 '24 12:08 Conan-Kudo

ok for me.

mwilck avatar Aug 26 '24 07:08 mwilck

I do not understand why we need to pull such a complex thing as NetworkManager and dbus into initrd...

mikhailnov avatar Oct 08 '24 16:10 mikhailnov

I do not understand why we need to pull such a complex thing as NetworkManager and dbus into initrd...

I find it hard to find out what action is expected to be taken on this comment here upstream. Can you please file a bug and include additional information (such as https://abf.io/import/dracut/blob/rosa2023.1/0026-Revert-chore-drop-support-for-ifcfg.patch) on what actions you expect from upstream maintainers who are reading this comment. Thanks @mikhailnov .

jozzsi avatar Oct 10 '24 23:10 jozzsi

I interpret @mikhailnov's comment as an argument against this PR. Some people are trying to simplify the initrd, and not everyone uses systemd; for these users, the simplest possible networking module makes some sense.

OTOH, this module has been unmaintained for some time, and @mikhailnov, you can re-add it in your environment if you need it. Therefore I still second this PR.

mwilck avatar Oct 11 '24 08:10 mwilck

complex thing as NetworkManager and dbus ..

From this comment I led to believe that @mikhailnov believes that because ifcfg is now removed NetworkManager is the only remaining option for networking. This is not true. In addition to NetworkManager, network-legacy, systemd-networkd and perhaps also connman is still expected to work (and none of it has a hard dependency on ifcfg). See https://github.com/dracut-ng/dracut-ng/blob/main/modules.d/40network/module-setup.sh#L14

jozzsi avatar Oct 11 '24 12:10 jozzsi