tmux icon indicating copy to clipboard operation
tmux copied to clipboard

Use typeable word for custom padding instead of zero-width space

Open luftaquila opened this issue 4 weeks ago โ€ข 1 comments

This PR resolves #372 .

Although the issue is not always able to reproduce, I believe it is better to use a normal word instead of a specific unicode byte.

It should not affect any previous configs, including the people who were using U+200B as their padding.

Thank you!

luftaquila avatar Dec 17 '25 02:12 luftaquila

๐Ÿ“ Walkthrough

Walkthrough

This PR updates the tmux Dracula configuration to support setting padding to false instead of using zero-width space characters. Changes include documentation updates and script logic to normalize the boolean value to empty strings for padding removal.

Changes

Cohort / File(s) Summary
Documentation
docs/CONFIG.md
Updated padding configuration guidance to use boolean false value instead of zero-width space character; removed old example and added new examples demonstrating false value assignment.
Script Logic
scripts/dracula.sh
Added normalization guards to convert left_pad and right_pad from false to empty strings, preventing padding application when explicitly disabled.

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~8 minutes

  • Verify normalization guards are placed at the correct location in the script before pad_script construction
  • Confirm that converting false to empty strings handles all edge cases and doesn't introduce unintended side effects in status bar rendering

Possibly related PRs

  • dracula/tmux#352: Introduces the customizable padding feature that this PR enhances by adding boolean false handling to replace the problematic zero-width space approach.

Suggested reviewers

  • ethancedwards8

Pre-merge checks and finishing touches

โŒ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage โš ๏ธ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
โœ… Passed checks (4 passed)
Check name Status Explanation
Title check โœ… Passed The title accurately reflects the main change: replacing zero-width space with a typeable word (false) for custom padding configuration.
Description check โœ… Passed The description is directly related to the changeset, referencing issue #372, explaining the motivation for replacing zero-width space with a normal word, and noting backward compatibility.
Linked Issues check โœ… Passed The PR successfully addresses issue #372 by replacing zero-width space padding with a boolean false value, preventing the status bar breaking issue caused by U+200B characters.
Out of Scope Changes check โœ… Passed All changes are directly related to fixing the padding issue: documentation updates explaining the new false-based approach and code changes normalizing false padding values to empty strings.
โœจ Finishing touches
  • [ ] ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 17 '25 02:12 coderabbitai[bot]