logseq
logseq copied to clipboard
add multi-color highlight support
Solves #13
- Update readme with reference of multi-color highlight
- update license to include license of original highlight repo and its reference
If you're fixing a UI issue, make sure you take two screenshots. One that shows the actual bug and another that shows how you fixed it.
Hey @kinalmehta Can you add a screenshot of the new feature? Thanks a lot for the contribution!
I'm not yet familiar with logseq plugins support but do we have to add the js code of the plugin too? Wouldn't it work if we just add support for the css variables? It seems that the PR will actually add the plugin into logseq Dracula which is not what dracula theme is about, we mostly want to add support for the plugins colors/css variables.
What you're saying is correct. Just adding the CSS support for colours should ideally work. But it seems the repo I linked is no longer maintained and is not present in the logseq plugins marketplace. So I had to add it to this repo itself.
This is another theme which supports colorful highlight but even here you have to manually set it up instead of directly installing from logseq marketplace.
Hope this makes sense.
Thanks
Hey. Just got to know that the highlight plugin will be uploaded to marketplace in few weeks. So maybe just adding proper color cas would be a better way to do it as you said earlier.
I'll update the PR to do that once the highlight plugin is available on marketplace.
Hey @kinalmehta Any updates?
Hey @SlyBouhafs,
The original author has still not pushed the highlight plugin on logseq-marketplace. Any suggestion from your side on how to proceed?
Thanks