gitk icon indicating copy to clipboard operation
gitk copied to clipboard

'found' text hard to read

Open lemzwerg opened this issue 2 years ago • 7 comments

If I search for some text, the found text is highlighted with a yellow background but with a white foreground, which makes it very hard to read.

I see a currentsearchhitbgcolor property. Does a currentsearchhitfgcolor exist, too?

This is on openSUSE GNU/Linux using gitk coming with git 2.40.1.

image

lemzwerg avatar May 09 '23 05:05 lemzwerg

BTW, in the image you can also see that the 'up' and 'down' buttons after the 'Lines of context' field don't fit the dark theme, inspite of having want_ttk 0 in my config file. Is this a known problem?

lemzwerg avatar May 10 '23 04:05 lemzwerg

Thanks @lemzwerg, unfortunately the yellow color doesn't come from currentsearchhitbgcolor. I have tried changing all the yellow-ish values to black in my config and this remained yellow. I believe gitk doesn't give us the option to tweak this color unfortunately.

And I believe the same applies for the 'up' and 'down' buttons your are mentioning.

lourot avatar Jun 14 '23 14:06 lourot

OK, thanks. Please file an issue for gitk so that it gets fixed eventually!

lemzwerg avatar Jun 14 '23 15:06 lemzwerg

gitk's source code is mirrored at https://github.com/git/git/tree/master/gitk-git and I think issues have to be reported on the mailing list described at https://git-scm.com/community

lourot avatar Jun 14 '23 16:06 lourot

OK. Sorry that I don't volunteer by myself, but don't have time to handle this additionally.

lemzwerg avatar Jun 14 '23 16:06 lemzwerg