NevolutionX icon indicating copy to clipboard operation
NevolutionX copied to clipboard

settingsMenu: Add system files dumper

Open dracc opened this issue 3 years ago • 4 comments

dracc avatar Dec 21 '21 15:12 dracc

https://github.com/dracc/NevolutionX/blob/1015b98ce3aa009f0b0a3862505ec2dc47b6373f/Sources/dumper.cpp#L22

I'd argue that this line is not necessary, as close() calls flush() anyway. Is it placed there just for clarity?

kosmas12 avatar Dec 21 '21 16:12 kosmas12

https://github.com/dracc/NevolutionX/blob/1015b98ce3aa009f0b0a3862505ec2dc47b6373f/Sources/dumper.cpp#L22

I'd argue that this line is not necessary, as close() calls flush() anyway. Is it placed there just for clarity?

I'd argue .close() is unnecessary too. I'll make sure to remove both. Thanks!

dracc avatar Dec 22 '21 13:12 dracc

I'd be interested in a config sector, and eeprom dumper in the future perhaps you could abstract more?

GXTX avatar Dec 22 '21 21:12 GXTX

I'd be interested in a config sector, and eeprom dumper in the future perhaps you could abstract more?

EEPROM dumper has been added. Dumping routines are small enough that I don't think abstraction is really necessary.

dracc avatar Jan 05 '22 22:01 dracc