dr4ft icon indicating copy to clipboard operation
dr4ft copied to clipboard

"Game over" error aborting draft

Open Modedrain opened this issue 5 years ago • 11 comments

Firstly, thank you for an amazing website.

Yesterday my friends and I were cube drafting. We were 4 people in total, drafting 5 packs, with the "leisurely" time setting. Somewhere in the middle of the fifth and last pack all of us were instantly booted from the draft with a red "game over" error text in red. I'll attach a screenshot.

Obviously we have no idea what caused this, but speculate the draft might have some hidden time limit or similar? I'd say we were pretty much exactly an hour in when the error hit us.

Would this be possible to fix? Is there any way we can avoid this in the future other than simply drafting more quickly? Thanks again!

IMG_20200118_121903

Modedrain avatar Jan 18 '20 11:01 Modedrain

Hi,

Yes you're right about the time: we stop every game an hour after it started. Doing so we ensure that we don't have any dead game.

We could increase the amount of time before the game is over. Maybe 2 hours could be fine?

HerveH44 avatar Jan 18 '20 20:01 HerveH44

Two hours would be great

Modedrain avatar Jan 18 '20 21:01 Modedrain

I didn't know this was a thing, interesting. I'd bump it to 1.5hrs as a start.

ZeldaZach avatar Jan 18 '20 21:01 ZeldaZach

My friends and I experienced this issue at the very end of our draft despite the increased timeout (assuming that was fixed). I'm wondering why this timeout isn't based on player activity? We were literally last pack last pick and had no way to save our decks. Might want to reopen this issue since this could be a problem, especially with newer players.

mbankim avatar Mar 07 '21 07:03 mbankim

@mbankim how long was your session open?

tooomm avatar Mar 07 '21 11:03 tooomm

Yeah could be possible to time since last activity. Would be good to know how prevalent this big is before committing time and work

mixmix avatar Mar 07 '21 19:03 mixmix

Relevant files https://github.com/dr4fters/dr4ft/search?q=Expires&type=

mixmix avatar Mar 07 '21 19:03 mixmix

Could perhaps change this logic

if (game.expires < now) { game.kill("game over"); }

So that it checks if game.isActive then run the game.renew() instead of game.kill to auto extend.

What we need to know is what counts as "active" for players. Probably we want to record when a game started, then auto extend until we reach some max (3 hours?) then kill the game

Ideally the ui would also tell people their game was going to expire when it was getting close

mixmix avatar Mar 07 '21 20:03 mixmix

@tooomm iirc it was about 90 minutes so it seems to be working as intended, though it's not a great user experience when the room closes

I think a warning in the UI is a good first step

mbankim avatar Mar 07 '21 21:03 mbankim

it's not a great user experience when the room closes

I think a warning in the UI is a good first step

Agreed!

The idea to refresh the timer on activity could be an interesting solution.


New issue?

tooomm avatar Mar 09 '21 15:03 tooomm

Refresh the timer on activity is really a good solution. I and my friend just experienced this issue. So sad...

laxect avatar Mar 26 '21 16:03 laxect