dr4ft icon indicating copy to clipboard operation
dr4ft copied to clipboard

Better bots

Open mixmix opened this issue 2 years ago • 5 comments

This PR creates bots that do more than pick randomly:

  • for the first 6 picks, it chooses the rarest card in the pack
    • if there are ties it choose randomly among them
  • after 6 picks, it choose it's 2 colors - these are just the 2 most common colors from pick so far
  • for subsequent picks the bots chooses the rarest cards in it's colors
    • if it can't, then it choose the rarest card (or was it a random card)

This is a super simple improvement. Lots of space for improvement AND play-testing suggests it's already a massive improvement - you don't get bots wheeling bombs and random players getting way overpowered... but you do get bombs wheeling in packs 2-3 more because the bots aren't in those cards colours.

you can try it out here : http://magic.protozoa.nz:1337

mixmix avatar Apr 19 '23 11:04 mixmix

I'm open to merging as-is and seeing how things change over time

ZeldaZach avatar Apr 19 '23 14:04 ZeldaZach

We should be passing our tests first thought @mixmix

ZeldaZach avatar Apr 19 '23 14:04 ZeldaZach

I have a bad feeling there is an intermitently failing test. Oh yeah its a pack making function - not all packs are unique cards for some sets. I started looking into it, but it was a bit opaque

mixmix avatar Apr 19 '23 19:04 mixmix

Ok my bad there were some linting things with semi-colons :vomiting_face: But we still have an intermittently failing test on Pool creation for some sets. It's in master

mixmix avatar Apr 25 '23 21:04 mixmix

arg... no idea why this is failing...

image

mixmix avatar Apr 25 '23 23:04 mixmix