dr4ft icon indicating copy to clipboard operation
dr4ft copied to clipboard

Published 20 hours ago • verified publisher icon dr4fters

Open links in secure new tabs

Open tooomm opened this issue 3 years ago • 2 comments

Explanation of the issue

Links took users away from dr4ft page.

Description of your changes

Open links in new tab instead. It's suggested to secure them with rel="noreferrer" as well.

tooomm avatar Feb 09 '21 20:02 tooomm

So what's the problem with these that you've found @tooomm - do they not behave as expected?

mixmix avatar Feb 11 '21 09:02 mixmix

The ones I changed in this PR work just fine.

Can you please adjust the ones in the footer (https://github.com/dr4fters/dr4ft/blob/tooomm-patch-8/frontend/src/lobby/Version.jsx#L14) properly to improve them as well? That would be cool. I'm not exactly sure how to correctly include it there.

tooomm avatar Feb 11 '21 15:02 tooomm