dr4ft icon indicating copy to clipboard operation
dr4ft copied to clipboard

Bug: Draftlog download button is missing from new GUI

Open JimroidZeus opened this issue 4 years ago • 8 comments

The draftlog download button does not appear as part of the download options section in the current release.

JimroidZeus avatar Feb 09 '21 02:02 JimroidZeus

Thanks for the report, will check in on this. I think I made it so it would only show when the draft was complete but there could be a bug

mixmix avatar Feb 09 '21 04:02 mixmix

I couldn't reproduce this. Can you give me more detail about what your game setup was?

Here's what I did as an example

  • set up a draft game selecting 1 pack, 2 players, innistrad
  • start draft, pick all my cards
  • game is finished I see the export option.

The logic around this checks if the gametype includes the word "draft" (using internal codes for types) If it doesn't then you won't see the draft log option

mixmix avatar Feb 09 '21 06:02 mixmix

@JimroidZeus For me it works just fine.

Note, that it looks different now, and draft logs have their own section: export


it would only show when the draft was complete

That is corect, it has been like that for a while.

tooomm avatar Feb 09 '21 13:02 tooomm

@mixmix It was a group of 4 actual players and the rest were bots. We were drafting a cube. I'm pretty sure that the draft log download box did not appear for any of us, it definitely did not appear for me.

We were drafting using the https://beta-dr4ft.herokuapp.com version. Here's the URL we used, not sure if that's helpful or not.

https://beta-dr4ft.herokuapp.com/#g/b44451b0-6a7b-11eb-abfe-3152f597c7e7

I tried reproducing this morning on dr4ft.info, and the beta app, with a 1 player cube draft and the button did show up this time on both of them.

JimroidZeus avatar Feb 09 '21 13:02 JimroidZeus

I think maybe we need the version of the app displayed on the footer of games as well because that would let us know more about what the conditions were for the bug

On Wed, 10 Feb 2021, 02:49 JimroidZeus, [email protected] wrote:

@mixmix https://github.com/mixmix It was a group of 4 actual players and the rest were bots. We were drafting a cube. I'm pretty sure that the draft log download box did not appear for any of us, it definitely did not appear for me.

We were drafting using the https://beta-dr4ft.herokuapp.com version. Here's the URL we used, not sure if that's helpful or not.

https://beta-dr4ft.herokuapp.com/#g/b44451b0-6a7b-11eb-abfe-3152f597c7e7

I tried reproducing this morning on dr4ft.info, and the beta app, with a 1 player cube draft and the button did show up this time on both of them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dr4fters/dr4ft/issues/1445#issuecomment-775949862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUK3HTREMPC3P7TXHU4YNTS6E4OHANCNFSM4XKEAV4Q .

mixmix avatar Feb 09 '21 19:02 mixmix

I unfortunately don't have that information for you. I will close the issue based on multiple commenters (myself included) not being able to reproduce.

Should it happen again I'll record more information and reopen / re-submit.

JimroidZeus avatar Feb 09 '21 19:02 JimroidZeus

@JimroidZeus try to use the main side (dr4ft.info) please, we can check the logs then for more details if it happens again.

The beta should only be used for test purposes or if there is an issue with the normal site. It's constantly changing and can contain more bugs.

tooomm avatar Feb 09 '21 19:02 tooomm

Finished a draft this evening and one person in the playgroup couldn't see the download draftlog button after completing the draft. Myself and others could still see the download draftlog button.

Here is the url: https://dr4ft.info/#g/28978bc0-a881-11eb-bfa1-43dd31a0d5f4

JimroidZeus avatar Apr 29 '21 02:04 JimroidZeus