David Chase

Results 89 comments of David Chase

@ydnar - it depends. On some architectures the stack is not very aligned, and so extra-aligned data is heap-allocated instead. Otherwise, yes, probably. And I am fine with `HostLayout`, will...

Would like to additionally require that this directive-typed field must appear before any field with greater-than-zero size, if that's okay? (This should not be requirement for some imagined other directives,...

Simplifies the implementation ever-so-slightly (avoids a pre-pass over structure fields), also makes its use more uniform, and I don't see much harm in the restriction (which could be relaxed later...

@iant I am okay with that also. @ydnar _ fields can have width. A zero-width (field) type is either an array of zero elements, a struct of zero fields, or...

I checked that adding the documentation would work (the bug referenced by gabyhelp made me wonder) so I think a pull request would be fine. There may be some back-and-forth...

I tried, with a very similar configuration (Darwin-amd64, using 1.22.4 as the building compiler, building at tip, similar settings in goenv), but could not reproduce.

and perhaps we put a PGO-informed TODO on the switch code? If the profile is true, that might be really helpful.

So not exactly a bug, but TestScript could tidy up its environment a little better?

To be more concrete, I was looking at the benchmarks in `wazero/internal/integration_test/bench`. Based on remarks above, I think that means I maybe want these? ``` BenchmarkInvocation/interpreter/string_manipulation_size_50 BenchmarkInvocation/interpreter/fib_for_20 BenchmarkInvocation/interpreter/random_mat_mul_size_20 BenchmarkCompilation/with_extern_cache BenchmarkCompilation/without_extern_cache...