Dana Paige Seidel
Dana Paige Seidel
Thanks @clauswilke - the palette idea would solve the variability issue I mentioned above. I just need to think critically about how to choose and document these palettes.
So I've implemented most of your suggested changes at least enough so that we can iterate on them. A couple notes: 1. I've removed the `expr()` wrapper which makes a...
Sorry for the long delay on my end, getting back to this now. I have just embedded and implemented `from_theme()` as suggested by @hadley and refactored `element_geom()` as suggested by...
Oh, interesting. Yes I suspected we would need to make a change in vdiffr but ggplot2 actually already has it's own `theme_test()` https://github.com/tidyverse/ggplot2/blob/5f49fb4a7b5624f9cc5b8011fc98909d7dbb23fe/R/theme-defaults.r#L500 It's just not yet used by vdiffr,...
@thomasp85 has suggested I wait on refactoring `GeomSf` to handle themeable aesthetics given his intention to overhaul GeomSf performance in the near future. If there is interest in moving this...
Hey team, I'm so glad there is still interest in this feature! I continue to think this would be really cool and am sorry I let it lie fallow for...
Hi all, As of these most recent commits, all geoms now respect default aesthetics set by themes :tada:. Currently I’ve only done this for color, fill, and some text aesthetics...
I agree.
## Passing The only thing keeping us from a passing build is security: > The project MUST have at least one primary developer who knows how to design secure software....