Nizo Priskorn

Results 138 comments of Nizo Priskorn

Data classes seem nice 😃

I have tried twice using dataclasses in my tools. Both times I get weird errors and classes that are not properly initialized. I suggest we wait with dataclasses until it...

Pydantic BaseModel is a nice alternative to data classes IMO. The only caveat is that __init__()/post_parse_init() does not exist. You have to call it manually after instantiation. That is a...

https://www.doxygen.nl/index.html seems like a better choice. Then the class hierarchy is generated. Then we don't have to manually keep it updated. #296

I see that it does use request sessions, so this should be straight forward no?

I would like to add a reference to the claim also. Does LexData support that? If not, how do I get the claim GUID after adding with LexData? I need...

OK I understand. I really like the idea and it seems very promising 😃 I have a suggestion. Look up videos on design sprint 2.0 and the contact me if...

@camelCaseNick The idea is to have the user and their needs at the core. Design sprint 2 is best explained by the videos liked from the items in this qid...

I just checked out the branch, built an xpi and tested it and got "undefined" ![bild](https://user-images.githubusercontent.com/68460690/153495468-68b6d785-cab9-410a-87e5-ad3f00259fd5.png) ![bild](https://user-images.githubusercontent.com/68460690/153495602-172671d1-a9cc-4c5d-90a0-9286f7192cb5.png) Also I tried following https://www.zotero.org/support/dev/client_coding/plugin_development#setting_up_a_plugin_development_environment but got no error nor a working plugin...

![bild](https://user-images.githubusercontent.com/68460690/153573440-da73479c-ac96-4161-9688-beb8b195aa12.png) ![bild](https://user-images.githubusercontent.com/68460690/153573769-0d84dfb6-0bd7-4f88-9ff8-b41b71a5937b.png) ``` getFromCrossref: function(menuName) { // get items selected // filter items with doi // generate batch call to crossref // only add items not available locally yet let...