Darren Loher

Thanks for the conversation. Those examples of canonical forms applied to a single type make sense to me. But here we are dealing with a union datatype. For option 1,...

Thanks for finding this. I think the RFC's requirement is a good idea. I will take your proposal to make this model rfc7950 compliant to the OC operator's meeting next...

@mryuezhang thanks for reporting this issue. Would you like to create a PR to propose a fix for this?

It does seem odd that DAC connector is in the optical module as a FIBER_CONNECTOR_TYPE. Agreed that adding CONNECTOR_TYPE to platform-types as the 'root' sounds ok and adding DAC_CONNECTOR as...

Thanks Rob, will cover this in the Aug 30 Openconfig Operators meeting

This was covered in Aug 30 meeting without objection. Will merge on Sep 2nd. (14 days after [commits](https://github.com/openconfig/public/pull/625/commits/0711e904e77a2f33962806a45be92ad99e5bafe2) which moved this to the p4rt model) if there are no further...

/gcbrun

@sbarguil can you please provide the following: reference to at least 2 vendor implementations of this feature (urls to documentation is great) For convenience for reviewers, can you provide the...

/gcbrun to re run checks

To address the repetition of the key-auth, perhaps a new keychain/openconfig-keychain-common.yang could be introduced. Also, I think a leaf for auth-type is missing. Ref using isis example: https://github.com/openconfig/public/blob/b34db05e8cf2efe69df3762d4bbd80665e1f9e79/release/models/isis/openconfig-isis.yang#L292-L327