Darren Loher

Results 447 comments of Darren Loher

@LimeHat > > introduced new OC subtree (/qos/input-policies) > > The operational use case is to configure schedulers (policers) on input subinterfaces > > Today OC requires definition of queues...

@LimeHat I like the `/qos/policer-policies/` concept better, so I revised the proposed structure to use it. WDYT now? Let's generate some rough consensus on the structure here. The NHG as...

I made a major revision of the scheduler configuration to align with the current, unmodified OC /qos model. Note that the input-queue is a _dummy_ queue required to satisfy the...

@LimeHat @nandanarista @earies @rgwilton for comment on the QoS model for ingress policing example here.

@vishnureddybadveli this is ready to merge, noting that there are a few TODO items. You can take up updates for future revisions.

Thanks for all the comments. CLosing this and tracking development here on the [dp-2.2 branch](https://github.com/openconfig/featureprofiles/blob/dp-2.2/feature/qos/otg_tests/ingress_police_nhg/README.md). When it's closer to ready to be merged, a new PR will be created.

> Overall changes are good. @vishnureddybadveli see latest change at: https://github.com/openconfig/featureprofiles/pull/3363/files/bfcadd11237ec96f7872a88a8062346d74f55695..b5f414856305b5b065d61067598b3d80baa678e8 - I added a commit correcting the UDP to GRE encap for the default encap gRIBI entry. Also I...

> > introduced new OC subtree (/qos/input-policies) > > The operational use case is to configure schedulers (policers) on input subinterfaces > > Today OC requires definition of queues for...

@trlongth @jaingaurav12 all comments addressed. Please review, thanks.

I made a couple of corrections and I think this is looking good now with no planned changes.