Dalibor Plavcic

Results 13 comments of Dalibor Plavcic

Hi @[chibenwa](https://github.com/chibenwa), can you still reproduce this if invalid `config.json` file is provided? > Reference: https://issues.apache.org/jira/browse/INFRA-22697 > > Apparently testcontainers requires $HOME/.docker/config.json to be a valid JSON file. > >...

> @cadonna and @dplavcic I hope that the new version has addressed all comments up to now. Thank you in advance for the review! LGTM!

Regarding "Notes to help the reviewers": > 1. Mockito does not have `verifyAll()` hence each mocked function call needs to be verified individually. This depends on the `strictness` level used...

Just one more question. Do you maybe have `jacoco` test coverage reports before and after these changes? I think `jacoco` reports would be useful to confirm we are still covering...

Hi @clolov, just an info, to avoid duplicate work.. I've started working on this one few days ago. There is a Jira ticket: [Replace EasyMock and PowerMock with Mockito for...

Hi @C0urante, I'm really sorry but I didn't have time to complete this on planned schedule (last week). It would be awesome if someone else can complete this (and unblock...

> Thank you for the reply @cadonna! Okay, I will wait for a week starting today and I will try to reach out to @wycccccc over email as well should...

@ableegoldman, @cadonna could you please help review this changes in the streams test domain?