kafka-python icon indicating copy to clipboard operation
kafka-python copied to clipboard

Add tests for KafkaAdminClient

Open jeffwidman opened this issue 7 years ago • 1 comments

I need to add tests for the KafkaAdmin changes I made:

  1. #1639
  2. #1640
  3. #1641
  4. #1642
  5. #1643
  6. #1645

I didn't have time yet to do tests... Given that the existing KafkaAdminClient code currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.

Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing #1193, as that will both simplify the code drastically and require a few fixture changes.

And then after that tackle the tests/missing coverage.

But creating this and assigning it to myself so that I don't forget

jeffwidman avatar Nov 18 '18 00:11 jeffwidman

I am unlikely to get to this as my day job no longer involves Kafka.

PR's welcome if anyone is interested!

jeffwidman avatar Feb 12 '20 20:02 jeffwidman