Flask-AppBuilder icon indicating copy to clipboard operation
Flask-AppBuilder copied to clipboard

Published 20 hours ago • verified publisher icon dpgaspar

Fix for issue #759

Open nachtkinder opened this issue 6 years ago • 3 comments

This is a fix for issue #759 relating to checkboxes in related views.

nachtkinder avatar Jun 08 '18 09:06 nachtkinder

Hi @nachtkinder thanks for your help. I am happy you are bearing with me on this.

It looks good but there is still an issue. I could replicate your issue and can see that your solution mostly fixes it. But if I click the check-all on the first tab, leave them checked and then go to the second tab, the check-all doesn't work anymore. And if I then go back to the first tab, the check-all then works in the opposite way that checking it, unchecks all, and unchecking the check-all checks all the other ones.

I have updated my single file app gist that shows the behavior with your fix.

dolfandringa avatar Oct 26 '18 02:10 dolfandringa

Coverage Status

Coverage decreased (-0.2%) to 70.34% when pulling 9a2ef4dfed55bc8962e403a257366aaade624b0c on nachtkinder:issue#759 into 836781d76dd08884a2141b67349461e34402660f on dpgaspar:master.

coveralls avatar Feb 08 '19 19:02 coveralls

Coverage Status

Coverage decreased (-0.2%) to 70.34% when pulling 9a2ef4dfed55bc8962e403a257366aaade624b0c on nachtkinder:issue#759 into 836781d76dd08884a2141b67349461e34402660f on dpgaspar:master.

coveralls avatar Feb 08 '19 19:02 coveralls