Flask-AppBuilder icon indicating copy to clipboard operation
Flask-AppBuilder copied to clipboard

fix: respect scale for SQL type NUMERIC

Open goerch opened this issue 2 years ago • 1 comments

Description

When testing with different SQL numeric types like NUMERIC, NUMERIC(14, 2), NUMERIC(14, 4) we noticed that the views always show two decimal places. This fix respects the SQL schema.

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [x] Is CRUD MVC related.
  • [ ] Is Auth, RBAC security related.
  • [ ] Changes the security db schema.
  • [ ] Introduces new feature
  • [ ] Removes existing feature

goerch avatar Nov 08 '23 15:11 goerch

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (59db85d) 79.31% compared to head (f727f2a) 79.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2159   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files          72       72           
  Lines        8974     8970    -4     
=======================================
- Hits         7118     7115    -3     
+ Misses       1856     1855    -1     
Flag Coverage Δ
python 79.31% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 26 '23 09:11 codecov[bot]