Flask-AppBuilder icon indicating copy to clipboard operation
Flask-AppBuilder copied to clipboard

fix: Actions from different views on same page

Open Dosenpfand opened this issue 1 year ago • 5 comments

Description

When having a page with different views e.g. a main and one or multiple related views with actions, they do not work as intended as all HTML <form>s will have the same ID action_form. This PR fixes the issue by appending the model view name to the ID.

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Is CRUD MVC related.
  • [ ] Is Auth, RBAC security related.
  • [ ] Changes the security db schema.
  • [ ] Introduces new feature
  • [ ] Removes existing feature

Dosenpfand avatar Mar 20 '23 21:03 Dosenpfand

Codecov Report

Merging #2008 (6fc1cb8) into master (f591ee5) will increase coverage by 4.04%. Report is 2 commits behind head on master. The diff coverage is n/a.

:exclamation: Current head 6fc1cb8 differs from pull request most recent head 3b91a7f. Consider uploading reports for the commit 3b91a7f to get more accurate results

@@            Coverage Diff             @@
##           master    #2008      +/-   ##
==========================================
+ Coverage   74.50%   78.54%   +4.04%     
==========================================
  Files          72       72              
  Lines        8970     8698     -272     
==========================================
+ Hits         6683     6832     +149     
+ Misses       2287     1866     -421     
Flag Coverage Δ
python 78.54% <ø> (+4.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

codecov[bot] avatar May 12 '23 10:05 codecov[bot]

Hi @dpgaspar, is there a chance to get this merged soonish?

Dosenpfand avatar Jun 22 '23 06:06 Dosenpfand

@dpgaspar , I applied the fix on the current tip of master. Please let me know if there is anything else I can do to get this merged. Thanks!

Dosenpfand avatar Oct 28 '23 15:10 Dosenpfand

@dpgaspar , It would be very nice to apply this patch.

Thanks

DBREngineer avatar Jan 30 '24 21:01 DBREngineer

@dpgaspar I think this PR would make #2219 obsolete. Is there a reason why this PR was never accepted ?

ThomasP0815 avatar Mar 07 '24 07:03 ThomasP0815