Flask-AppBuilder icon indicating copy to clipboard operation
Flask-AppBuilder copied to clipboard

refactor Adding FilterMatch, Allow Multiple Columns Ordering, Fixes Filter front_end #1983

Open gbrault opened this issue 3 years ago • 2 comments

Description

ADDITIONAL INFORMATION

Fixes #1983

  • [ ] Has associated issue:
  • [ ] Is CRUD MVC related.
  • [ ] Is Auth, RBAC security related.
  • [ ] Changes the security db schema.
  • [x] Introduces new features
  • [ ] Removes existing feature

gbrault avatar Jan 27 '23 11:01 gbrault

Codecov Report

Merging #1986 (7680054) into master (dcb32c7) will decrease coverage by 33.31%. The diff coverage is 15.78%.

:exclamation: Current head 7680054 differs from pull request most recent head 8ce1e81. Consider uploading reports for the commit 8ce1e81 to get more accurate results

@@             Coverage Diff             @@
##           master    #1986       +/-   ##
===========================================
- Coverage   78.13%   44.83%   -33.31%     
===========================================
  Files          71       71               
  Lines        8612     8501      -111     
===========================================
- Hits         6729     3811     -2918     
- Misses       1883     4690     +2807     
Flag Coverage Δ
python 44.83% <15.78%> (-33.31%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/models/sqla/interface.py 18.36% <0.00%> (-63.57%) :arrow_down:
flask_appbuilder/views.py 39.65% <25.00%> (-26.47%) :arrow_down:
flask_appbuilder/models/sqla/filters.py 45.08% <66.66%> (-36.36%) :arrow_down:
flask_appbuilder/security/sqla/apis/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
flask_appbuilder/security/sqla/apis/role/schema.py 0.00% <0.00%> (-100.00%) :arrow_down:
flask_appbuilder/security/sqla/apis/user/schema.py 0.00% <0.00%> (-100.00%) :arrow_down:
...ask_appbuilder/security/sqla/apis/role/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
...ask_appbuilder/security/sqla/apis/user/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
...ask_appbuilder/security/sqla/apis/view_menu/api.py 0.00% <0.00%> (-100.00%) :arrow_down:
...sk_appbuilder/security/sqla/apis/permission/api.py 0.00% <0.00%> (-100.00%) :arrow_down:
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jan 27 '23 11:01 codecov[bot]

I just used a clean appbuilder coming from your site and injected couple of changes that were not included and the automated workflow rejects almost everything: something must be wrong?

gbrault avatar Jan 27 '23 13:01 gbrault