Flask-AppBuilder icon indicating copy to clipboard operation
Flask-AppBuilder copied to clipboard

feat: Add groups to azure oauth2 provider role_keys

Open andersbjht opened this issue 3 years ago • 2 comments

Description

Add mapping from oauth groups to role_keys for azure.

It was only implemented for certain providers, like okta.

ADDITIONAL INFORMATION

In order to export "groups", also need to add "openid".

The default in Azure is to use the Group IDs as keys.

andersbjht avatar Nov 02 '21 07:11 andersbjht

Codecov Report

Merging #1730 (5de2134) into master (dd07c10) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1730   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          56       56           
  Lines        8114     8114           
=======================================
  Hits         6232     6232           
  Misses       1882     1882           
Flag Coverage Δ
python 76.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/manager.py 75.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd07c10...5de2134. Read the comment docs.

codecov[bot] avatar Nov 02 '21 07:11 codecov[bot]

@dpgaspar is there anything remaining before this can get merged?

hterik avatar Feb 21 '22 15:02 hterik