Iordanis Petkakis

Results 535 comments of Iordanis Petkakis

I like this addition, but it doesn't update the highlight for `foldopen` for me when I try locally your PR. Is there something else I'm missing? Maybe a setting in...

I mean that it doesn't inherit the color of gitsign. Following is a screencast [Screencast 2024-04-04 19:07:24.webm](https://github.com/LazyVim/LazyVim/assets/12776461/73b7dd29-224a-4652-bd42-726d52cd53ca) As you can see in the video, the `foldopen` icon doesn't inherit the...

I see that you're using your custom `statuscolumn`. Can you try with default LazyVim installation and confirm?

I tried your dotfiles and it does indeed inherit the color from gitsigns with your custom `statuscolumn`. But default LazyVim `statuscolumn` does not do that. So, this PR, without any...

Ok I deleted my previous post, because the solution was wrong. But this time I believe I got it right ```lua vim.api.nvim_win_call(win, function() if vim.fn.foldclosed(vim.v.lnum) >= 0 then fold =...

Ohhh I see. I was trying to get it done without that setting. Thanks for clarifying that and good luck with your PR :smile:

Might I suggest we also do the following change ```lua if LazyVim.opts("gitsigns.nvim").numhl == true then fold = { text = vim.opt.fillchars:get().foldclose or "" } else fold = { text =...

@lkhphuc I appreciate your effort but I believe it would be wiser to leave it to inherit the `numhl` color if the user has enabled it in his configuration. This...

I understand what you mean and in hindsight, after reading your explanation, I totally agree. Thank you for this PR and also explaining to me your logic. Really appreciate it.

Not sure about the usefulness of this. Pretty sure one would just open Neovim with a directory as argument for that. From dashboard it feels more natural to open the...