Iordanis Petkakis

Results 535 comments of Iordanis Petkakis

I don't think that's right. `inlay_hints` are enabled by default in LazyVim. So they should be enabled by default for Java as well. And the user can change that in...

But the purpose of this PR is to enable inlay hints in Java by default, since they're already enabled by default in LazyVim. Otherwise there's no purpose for this PR...

Sorry missed that. I'm just a regular user like you, so now all that remains is for the maintainer to look into it.

@idelice It works correctly on your side, right? Because I only tested on a crappy Java code snippet from GPT and I don't do Java as I've already mentioned. It...

@folke adding `LazyVim.toggle.hints(buffer, true)` in [here](https://github.com/LazyVim/LazyVim/blob/97862f425997bf89f581e6aeceed9aac85d90432/lua/lazyvim/plugins/lsp/init.lua#L126-L133) after the `lsp.keymaps.on_attach` and removing the one from the `LspAttach` autocmd in this PR also enables the inlay hints on a java file. I'm...

Yes, that was in the initial commit as well. Otherwise the user would have to do in his personal configuration ```lua java = { inlayHints = { parameterNames = {...

@idelice I agree with you. I mentioned that this was part of the initial commit in this PR and that it should also make it to the final version of...

I checked your commit. Look at these [lines](https://github.com/LazyVim/LazyVim/blob/e5ea8abd38c4b93edccd69c9ef4462377103a9c3/lua/lazyvim/plugins/extras/lang/java.lua#L162-L173). Here is where the `local config` gets evaluated. It merges the table ```lua { cmd = opts.full_cmd(opts), root_dir = opts.root_dir(fname), init_options =...

Both of them need the pattern `root_pattern("composer.json", ".git")` to attach correctly. Make sure you have either of those files at the root of your project.

This has nothing to do with LazyVim. This is how the LSP server is configured from [nvim-lspconfig](https://github.com/neovim/nvim-lspconfig/blob/0b8165cf95806bc4bb8f745bb0c92021b2ed4b98/lua/lspconfig/server_configurations/intelephense.lua#L7-L13). You should create an issue at the repo if you want this behavior...