New web platform test failures in 2.2.10

[domenic]

The following are the tests that fail in 2.2.10 which have been passing in 2.2.7:

• From https://github.com/web-platform-tests/wpt/tree/master/css/selectors
  • dir-pseudo-on-bdi-element.html
  • focus-display-none-001.html
  • focus-visible-014.html
• From https://github.com/web-platform-tests/wpt/tree/master/html/semantics/selectors
  • pseudo-classes/dir01.html
• From https://github.com/web-platform-tests/wpt/tree/master/dom/nodes/
  • Element-matches.html and Element-webkitMatchesSelector.html (basically duplicate tests)

[dperini]

Thank you @domenic ... I am working on the bugs/fixes you listed. Especially trying to resolve the is not a valid selector regression.

[alopix]

If it helps your debugging/fixing @dperini, a selector that has started failing with the latest 2.2.10 release is #main-content [class*="-Wrapper "]~[class*="-Paragraph "] which the is not a valid selector error. Not quit sure which part it does not like.

[dperini]

@alopix thank you for the help. Yes it is the same bug affecting everybody. Still need a couple of days working on it and testing.

[dperini]

@domenic the parsing bug was fixed and I believe I took care of all the other issues you mentioned above. You can tell if this is good enough for a new release on npm or if you need other changes/additions. Next release will be 2.2.12 and I will skip 2.2.11 as a marker of the problem I incurred with failing RE.

[dperini]

@alopix could you also check your problem has been fixed by these latest changes ? Thank you in advance for the great help and reviews.

[alopix]

@dperini thanks for working on this. I just checked and the selector seems to be working again with jsdom using your main branch 👍

[dperini]

@alopix thank you so much for the tests. Your help appreciated.

[moekify]

@dperini Any update on when you will release 2.2.12? :)

[dperini]

@moekify we are near to it ... very near. Anything you would like to see added or fixed ? Does nwsapi work for you in its current state.

[moekify]

No we definitely need the fix :) but not crazy urgent, just wanted to be able to communicate something upstream.

Thanks for your work on this :)

[dperini]

@domenic nwsapi Release 2.2.12 has just been pushed to npm.

[domenic]

All of these tests still fail with nwsapi 2.2.16.

In addition, a new test has started failing: ParentNode-querySelectors-namespaces.html. (I will edit the OP to include this.)

[dperini]

@domenic from the wpt testing I have set up it seems to me the only selector failing in your list is the SVG test. Anyway I will include all the wpt tests needed to ensure correctness of ŧhese resolvers and will check them again. I am pushing some more fix related to the :scope and the :has() selectors, probably tomorrow

[dperini]

@domenic maybe it's time for a release. Can you help with reviewing current code on GitHub. I believe I fixed the outstanding errors and added a new bunch of resolvers :has() and media pseudo-classes. I will try to add more pseudo-classes too and improve the previously added resolvers.

• namespaced attribute selectors in document with mixed contents fixed by e54a3dd6df9eb6076f38db576999ffa8e8af2f09
• pseudo-classes/dir01.html failure was fixed by ef2b23fc0660f2746ffc40b2d2f6751532741d07 and by e5fed5ed2208b92f3dccc19cefa851553dd0e2a0

[dperini]

@alopix @moekify

Will close this issue now. Reopen if needed.

[domenic]

I can't really test the current code on GitHub; I can only test releases. I periodically update nwsapi and will report back about which WPTs are passing or failing when I next do.