hvm icon indicating copy to clipboard operation
hvm copied to clipboard

haxelib 3.3.0 has a different lib name

Open jozefchutka opened this issue 8 years ago • 2 comments

jozefchutka avatar Feb 07 '17 13:02 jozefchutka

Aren't we going to break compatibility with pre 3.3.0 versions?

Instead we should do something like:

set -- "$VERSION"
IFS=","; declare -a Array=($*)
if [ "${Array[0]}" -gt "3" ] ||
	([ "${Array[0]}" -eq "3" ] &&
	([ "${Array[1]}" -gt "3" ] ||
	([ "${Array[1]}" -eq "3" ] && [ "${Array[2]}" -gt "0" ]))); then
	URL="http://lib.haxe.org/files/3.0/haxelib-$VERSION.zip"
else
	URL="http://lib.haxe.org/files/3.0/haxelib_client-$VERSION.zip"
fi

What do you think?

po8rewq avatar Feb 07 '17 16:02 po8rewq

Actually, it would be better to always use this url: https://github.com/HaxeFoundation/haxelib/archive/ There is a tag per version. Some are missing, but the majors are here.

See my changes on config.sh: https://github.com/po8rewq/hvm/commit/15c06157845973e7937ccce0b339b31d4ab3f36e

I didn't do the necessary changes for hvm versions haxelib.

po8rewq avatar Feb 08 '17 12:02 po8rewq