dpcollins-google

Results 20 comments of dpcollins-google

> Pls fix spotless. > > @@ -18,7 +18,6 @@ 17:22:48 package·org.apache.beam.sdk.io.gcp.pubsublite.internal; 17:22:48 17:22:48 import·static·org.junit.Assert.assertEquals; 17:22:48 -import·static·org.junit.Assert.assertThrows; 17:22:48 import·static·org.mockito.Mockito.verify; Done.

Sure. When building google-cloud-pubsublite, I get a lot of warnings like this with generated code: ``` [WARNING] /Users/dpcollins/Documents/java-pubsublite/google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/v1/PublisherServiceSettings.java:[127,17] [unchecked] toBuilder() in PublisherServiceSettings overrides toBuilder() in ClientSettings return type requires unchecked...

This is unclear, but I had not experienced this in the past, so it is likely a recent (O(months) though) regression. An example code snippet which triggered this from the...

I just created my own pipeline- I'm able to recreate this fairly frequently, where the future takes over a minute to finish. It has the following (truncated) stacktrace: ``` java.util.concurrent.TimeoutException:...

To provide more information, it appears that in this case the issue is with executor exhaustion at the GRPC layer preventing the grpc future from ever returning. However, it would...

The specific issue for me is with pubsublite, where the operation for SeekSubscription will never complete until the user connects a subscriber client for the first time or seeks again....

> The java code ... isnt the nodeid to node mapping I think it is? The mapping is just overridden, but this is the codepath called by https://github.com/apache/kafka/blob/27548707dd8f2324d27335edc922ae88d78d86ed/clients/src/main/java/org/apache/kafka/clients/Metadata.java#L278 when the...

> I had the impression that you wanted to find the node_id from the protocol, but it seems it's not passed, not even in the header. No, we're abstracting away...

Effectively, per the kafka protocol, the hostname should never be used for matching, only the node ID. Effectively, the change in https://github.com/confluentinc/librdkafka/commit/b09ff60c9e3e93815b3491f007460291858b3caf was intended as an optimization to "migrates bootstrap...

The proxy in question was for Google cloud Pub/Sub Lite, a similar partition based streaming system but without specific broker identities. I maintain that librdkafka is not following the protocol...