Dawid Ciężarkiewicz

Results 467 comments of Dawid Ciężarkiewicz

About the "loosing metrics in release" - you don't have to use `info!` or anything else - you could just use a similiar macro with the static logging level check...

Probably not. Weird that no one ever raised it.

> If you log (using error!, info!, warn! or debug!) when implementing Debug or Display, I'd say ... don't do it. :D

Seems to me like this should be implementable as a 3rd party library.

`slog-scope` is already a 3rd party library, yes.

You probably want to use it behind an `async` anyway (for perf.), but yeah ... it probably shouldn't be much work to fix this. Please fill a PR! :)

I have troubles checking multiple issue trackers. It's not ideal, but works OKish. Please just report the issues here. :)

Hmmmm.... That's a good point. I haven't thought about it this way (that `slog-async` is effectively doing `Clone`. I guess there's probably just one way to do it, so it...

Another solution is to implement a `Drain` that removes duplicates. This one is good because everyone can implement it on their own, and since they know which keys can change,...

@CodeSandwich Yes it is. You can serialize it into arbitrary `Serializer` https://docs.rs/slog/2.4.1/slog/trait.KV.html#tymethod.serialize and in that `Serializer` you can keep track of, skip, replace, and whatever you want with each key-value...