ripple-framework icon indicating copy to clipboard operation
ripple-framework copied to clipboard

Submit label depends on schema and unused key

Open waitingallday opened this issue 11 months ago • 0 comments

This is defaulting the analytics element_text to Submit which is probably right 99% of the time, but

  • FormKit schema doesn't use key
  • Doesn't check for components in the slot

https://github.com/dpc-sdp/ripple-framework/blob/2383bceda61c63f7c1cb0af645e188f148404e3f/packages/ripple-ui-forms/src/components/RplForm/RplForm.vue#L84

waitingallday avatar Mar 21 '24 03:03 waitingallday