supercell-wx icon indicating copy to clipboard operation
supercell-wx copied to clipboard

Move constructor safety

Open dpaulat opened this issue 1 year ago • 0 comments

Several classes are not move-safe. There are two potential problems;

  • Implementation has a reference to the interface that does not get updated on move
  • Lambdas capture "this", which becomes invalid after a move

The above issues should be addressed where possible, or move constructors deleted.

This is not currently causing any functional issues, as most classes are never moved, and move constructors are never called.

dpaulat avatar Sep 29 '23 13:09 dpaulat