cordova-custom-config icon indicating copy to clipboard operation
cordova-custom-config copied to clipboard

[FEATURE] Allow modifying other files than AndroidManifest.xml

Open calimeroteknik opened this issue 8 years ago • 3 comments

I was very happy to find this plugin, but I'd like to add resources in res/values/strings.xml. Could it be allowed? Well, that part isn't hard: there is a check for the filename to be 'AndroidManifest.xml', which can be removed.

However, the object PLATFORM_CONFIG_FILES's contents would need to be determined either by looking at the backup directory's contents, or the list of modified files in config.xml.

Here is the diff of the changes I made in order for it to work for one extra file: cordova-custom-config-additionalfile.txt

calimeroteknik avatar Jun 08 '16 12:06 calimeroteknik

@calimeroteknik the best thing for you to do would be to just create a custom plugin with a plugin.xml and add your customizations there. This plugin actually is an updated version of a hook I contributed to the yeoman ionic generator, and I created this for iOS/Android because I wasnt as familiar with custom plugins and plugin.xml. But if you get the hang of it, and create a custom plugin, you wont need this plugin and wont be limited on configuring your project

djett41 avatar Jan 30 '17 22:01 djett41

@djett41 Thanks for creating the original hook script. I really only created this plugin out of my necessity to customise the native project config in a CI (non-local) build environment and I think there's still a place for this plugin to avoid needing to create a custom plugin every time you want to customise the native project config. Having said that, I'm hoping that soon it will become redundant if Cordova itself is able to support in config.xml tags that are currently only supported by plugin.xml (e.g. <config-file/>, <framework/>, <source-file/>)

dpa99c avatar Jan 31 '17 08:01 dpa99c

@dpa99c no prob my man! youre right there is value to this plugin since Cordova still doesnt fully support certain things through the CLI

djett41 avatar Feb 20 '17 22:02 djett41