Byregot's Brow not calculated as 100% success rate on specialist

[mihawk90]

Required Information

Class: Culinarian (Specialist) Level: 70 Craftsmanship: 703 Control: 673 CP: 375 Recipe Name: Near Eastern Antique Recipe Level: 57 (Custom Delivery) Solver Seed: 177463

Expected Behaviour

Minimum Value in Quality stays at 2728.

Actual Behaviour

Minimum Value should be increased due to Byregot's Brow having 150 base efficiency (+ 1 stack Inner Quiet at minimum in the macro at the bottom). It also has 100% success rate on specialist, so it would be impossible for quality to stay at the initial value.

I suspect that Minimum Value isn't the only place where it's calculated incorrectly (can't really tell though :) ).

Steps To Reproduce

Food: Raw Oyster (had it laying around and rotting :D ) Starting Quality: 2728

Resulting macro:

/ac "Inner Quiet" <wait.2>
/ac "Advanced Touch" <wait.3>
/ac "Careful Synthesis III" <wait.3>
/ac "Great Strides" <wait.2>
/ac "Innovation" <wait.2>
/ac "Advanced Touch" <wait.3>
/ac "Great Strides" <wait.2>
/ac "Byregot's Brow" <wait.3>
/ac "Careful Synthesis III" <wait.3>
/ac "Careful Synthesis III" <wait.3>
/echo Macro #1 complete <se.14>

[doxxx]

Thanks for the detailed report! I’ll take a look soon.

[Ermad]

Even though Byregot's Brow does have a base efficiency, you aren't actually able to cast it in game until you have 2 stacks of Inner Quiet (one previous successful touch).

So it is correct to have it not increase the minimum quality, if you don't have any 100% success touch actions.

[mihawk90]

Hm... interesting 🤔 did no know that, never really payed attention. The tooltip doesn't specifically state that though (then again, sqex was never particularly accurate in their tooltips). It does say that the IQ effect ends upon use, but not that it's required :/

[mihawk90]

Just checked this ingame and @Ermad's information is correct.

Square Enix being hard at work again not stating anything about this (even trying to execute it without 2 stacks of IQ only states "Cannot execute at this time.", but not what the requirements are...)

Just tried it with another custom macro and it works as expected (besides the fact that we can add multiple Byregot's in Succession, but I think the solver accounts for that).

[Ermad]

That said we should have better support for actions that you are unable to cast because you don't meet the requirements. Currently they just dont apply their own effects (quality/progress gain and buffs), but they still cost CP, use durability, etc. It also isn't very obvious when you add an action that can't be executed at that point. I will work on improving it.

[doxxx]

Related to this, I recently added some options for the MonteCarlo simulation that controls how it deals with conditional actions that aren't usable at that point in the sequence due to the condition not being met. The "Macro Mode" will behave more closely to actual in-game behavior.

[Necromos]

Isn't it solved? There is this

    if (isActionEq(action, AllActions.byregotsBrow) && s.synth.crafter.specialist) {
        successProbability += 0.3
    }

inside of code, which should solve a thing, right?