downshift

downshift copied to clipboard

onSelectedItemChange is not fired if default highlighted index used

5

- `downshift` version: **v6.0.16** - `node` version: **v14.15.4** - `npm` (or `yarn`) version: **6.14.10** **Relevant code or config** added props to `useCombobox`: ```javascript defaultHighlightedIndex: 0, onSelectedItemChange: (val) => console.log('onSelectedItemChanged', val),...

devacc5566

[useSelect] Selecting item with spacebar in firefox reopens the menu

5

- `downshift` version: 6.0.6 - `firefox` version: 82.0.3 **Relevant code or config** Error present in reference implementation: https://www.downshift-js.com/use-select **What you did**: With firefox, open a menu and select an item...

lyml

getA11ySelectionMessage is not called

1

- `downshift` version: **v6.0.16** - `node` version: **v14.15.4** - `npm` (or `yarn`) version: **6.14.10** **Relevant code or config** a11y message functions overriden: ```javascript getA11ySelectionMessage: () => console.log('getA11ySelectionMessage'), getA11yStatusMessage: () =>...

devacc5566

getInputProps return type gives an opinion on props that it doesn't actually return

4

- `downshift` version: 6.0.5 - `node` version: - `npm` (or `yarn`) version: **Relevant code or config** ``` export interface GetInputPropsOptions extends React.HTMLProps { disabled?: boolean } ``` **What you did**:...

MarkFalconbridge

fix(typings): make item optional in GetItemPropsOptions

3

**What**: Making `item` optional in `GetItemPropsOptions` **Why**: The runtime works just fine with only an `index` value provided, but the typings _require_ an `item` to be provided. **How**: vim **Checklist**:...

knpwrs

Edit typing of selectItem to allow to set null

8

**What**: This PR enables to call `selectItem(null)` without having to typecast this at the call site in Typescript strict mode. **Why**: When `items` is a controlled prop, but `selectedItem` is...

fabb

**Relevant code or config** Avoid doing this: ```typescript onSelectedItemChange: ({selectedItem}) => { selectedItem && addSelectedItem(selectedItem) }, ``` **Problem description**: Since it's the handler for `onSelectedItemChange` the types should guarantee that...

silviuaavram

[useSelect] preventDownshiftDefault = true doesn't seem to be working with getToggleButtonProps

1

- `downshift` version: 4.0.2 - `node` version: 14.6.0 - ` yarn` version: 1.22.5 **Relevant code or config** ```javascript { if (e.key === 'Enter') { e.nativeEvent.preventDownshiftDefault = true } }, })}...

vtrpldn

highlightedIndex value should appear in the text field

9

- `downshift` version: 5.4.6 - `node` version: 12.13.1 - `npm` version: 6.12.1 - `yarn` version: 1.22.4 Hey, First thanks for the awesome library. I'am filtering data from the array of...

john45321

Add a `isItemDisabled` property to all the hooks

9

Usually, I get to the point where I have to disable some items from the list, so I have to create a custom callback, that runs like this on the...

pedroapfilho