dound
Add ndb support.
Thanks for the useful code!
I've made this modification to add ndb support; feel free to take it if you like.
That's a bunch of different changes. Some seem to break existing sessions. May I suggest breaking them down into separate pull requests? 6fced82 seems to be the most obvious candidate for that.
I'm not sure what you see, but I don't see a reasonable way to break that pr into multiples; it's fairly straightforward and actually shouldn't even break old-style sessions. Obviously discard if you like!
On 9/24/13 6:31 PM, Maximillian Dornseif wrote:
That's a bunch of different changes. Some seem to break existing sessions. May I suggest breaking them down into separate pull requests? 6fced82 https://github.com/dound/gae-sessions/commit/6fced82 seems to be the most obvious candidate for that.
— Reply to this email directly or view it on GitHub https://github.com/dound/gae-sessions/pull/40#issuecomment-24984042.
I mean that this actually consists of
- allow storing of ndb Objects in Sessions 6fced82
- switches to ndb for session storage d3fdc17
- allow to support old db backed sessions 878c41b - closely related to 2.
- adds some (experimental?) undocumented Cookie code 81565bc
I think breaking these down into different pull requests makes it much easier for the project owner (@dound) to evaluate merge them. From my personal experience I can say that the shorter the pull request the easier it get's accepted.
This is a reasonable analysis but at the same time, the changes are still straightforward and I have close to no investment in them being picked up by anyone else, so if the original developer is interested, he or she can incorporate some or all of them or not!
Just coming across this now. In the file there are some needed updates for DIRTY_BUT_DONT_PERSIST_TO_DB => DIRTY_BUT_DONT_PERSIST_xTO_DB
