Douglas Simon

Results 64 comments of Douglas Simon

Hi Andrew, we'd most likely want to port this to Graal. Just for my understanding, the current implementation of [secondary super cache lookup in Graal](https://github.com/oracle/graal/blob/0a471fc329ea2c8c18c05f9d83347dc1199c3ad9/compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/hotspot/replacements/InstanceOfSnippets.java#L169) will continue to work until...

My first suggestion is to stop using `graal-jvmci-8` (it is long dead) and use https://github.com/graalvm/labs-openjdk-20 instead.

> since there don't seem to be binaries at the moment The moment will be here for quite a while as stated in the release notes [here](https://github.com/graalvm/graal-jvmci-8/releases/tag/jvmci-21.1-b01).

Building these JVMCI JDK8 binaries is a 2 step process: 1. Build a base JDK and the `.a` files for the base JDK. 2. Build a JVMCI JDK with `mx...

In random order: * `graal-jvmci-8` is not a full JDK - it's just the `hotspot/` tree from a JDK8 forest. * This [repo](https://github.com/graalvm/openjdk8-jvmci-builder) is only used to host the binaries....

I've just pushed a change now that clarifies the current purpose of this repo.

You need to apply `jdk.patch` against http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk.

JDK JVMCI 11 is built from https://github.com/graalvm/labs-openjdk-11. You should be able to work out how to build it based on `ci.jsonnet`.

BTW, if you're interested in JDK 11, there is now a [build script](https://github.com/graalvm/labs-openjdk-11/blob/master/build_labsjdk.py) that should make life easier.

> It would be super useful if there's a build script for JDK8. We have a script for building the base jdk8 and static libs but it does little more...