Doug MacEachern
Doug MacEachern
Did you check the Releases page? https://github.com/vmware/govmomi/releases
govmomi has an option to set the `opID` for each API call, which VC will include in its log messages. This was added to support tracing. See for example: https://github.com/vmware/vic/blob/master/pkg/trace/operation.go#L77
Thanks @changemyminds , re-opened and will ping some folks to discuss
Thanks @priyanka19-98 , will try to review soon. Could you please [rebase](https://github.com/vmware/govmomi/blob/main/CONTRIBUTING.md#updating-pull-requests) ? (note how PR says your branch has "195 commits")
#3548 adds simulator support for the CryptoManager related APIs. @priyanka19-98 have not heard back from you, do you plan on continuing your work on this? If so, you'll need to...
You can use these helpers to get the details: https://github.com/vmware/govmomi/blob/7822b34eb5d359ddae2f93d356c78c5ea05784d5/vim25/soap/error.go#L109-L116
I think we could add a `-controller` flag to `vm.disk.change` to support this. What do you think?
@embano1 yes, I agree we should return the batch error from that method. Existing code should already check err != nil at least and the change won't break the method...
Finally got to a fix for this in #3476 and included a couple of new govc tpm commands. I'd not looked at anything tpm related before, but these commands are...
We use a custom [http.Transport.DialTLS](https://golang.org/pkg/net/http/#Transport) function to implement the [thumbprint check](https://github.com/vmware/govmomi/blob/93851bd6e14df055d86661de494119e6bacb2192/vim25/soap/client.go#L344), but that does not apply to proxy connections. Looks like we'd have to implement our own proxy client that...