LiveLessons icon indicating copy to clipboard operation
LiveLessons copied to clipboard

OneShotExecutorService Question

Open glideken opened this issue 10 years ago • 1 comments

Great lectures! This is not an issue but just a question that came to mind while reading OneShotExecutorService...

In OneShotExecutorService:processQueuedResults(), are having getQueue().take() in L196 and t.join() in L212 sufficient to ensure the tasks are finished than to also callCountDownLatch mExitBarrier.await() in L152? In other words, is the CountDownLatch necessary?

glideken avatar Jul 04 '15 06:07 glideken

Valid point, OneShotExecutorService:processQueuedResults() will return once it processes all results from the queue which in turn will only have all results after all threads have completed.

AmazingDonut avatar Mar 08 '16 02:03 AmazingDonut