BartRunnerAndroid icon indicating copy to clipboard operation
BartRunnerAndroid copied to clipboard

Unable to keep favorite route (S22 Ultra)

Open ynazar1 opened this issue 2 years ago • 6 comments

The app seems to unable to save favorite routes in S22 Ultra

Repro Steps:

  1. Add favorite routes (any number)
  2. Hard kill the app and reopen (same happens if OS kills it eventually; also with rebooting)
  3. No favorite routes

Info: Version: 2.2.21 Phone: Samsung S22 Ultra Android version: Android 12 (prior) and 13 (current)

Other: Clearing cache, uninstalling, etc; doesn't fix it.

ynazar1 avatar Dec 13 '22 21:12 ynazar1

Thanks for documenting this. This is a known issue, but I'm really struggling to find any time to work on the app these days. Hopefully someone out there might be able to contribute a fix 🤞

dougkeen avatar Dec 16 '22 16:12 dougkeen

I tried giving it a crack but couldn't get it to compile properly to run in the emulator without some serious hand-holding or directions. Unfortunately it's using fairly old gradle, java, and build system and overall I simply don't have the expertise to get it to a running state myself to debug. Sorry. :(

Hopefully you'll come back to it sometimes. A friend of mine cannot reproduce on Android 12 OnePlus phone... So it could be something odd with Samsung flavor of Android. But who really knows without full debug.

ynazar1 avatar Jan 26 '23 07:01 ynazar1

I seem to be running into this same issue on a Pixel 6, running 2.2.21 and Android 14. If there's additional debugging information I can provide let me know.

mr-ransel avatar Oct 25 '23 20:10 mr-ransel

I also started having this issue after updating my Pixel 5a to Android 14.

davidsgrogan avatar Oct 31 '23 16:10 davidsgrogan

I've never looked at android code before, but the persist/restore stuff is pretty simple. I wonder if the issue is saving or restoring. Maybe android started blowing away app-specific files more often? That doesn't make much sense...

Or maybe something with the Activities lifecycle guarantees changed making onStop no longer called when the author thought it would be, which means app.saveFavorites() isn't called when the Activity shuts down.

Just spitballing here. @dougkeen do any of these seem likely to be the mismatch between the code's expectations and what android actually provides? Do you have any general suspicions about the root cause of this issue?

davidsgrogan avatar Oct 31 '23 16:10 davidsgrogan

I haven't really looked deep enough to have any real suspicions, but this issue did start occurring after some Android upgrades (no app code changes), so it does seem like changes in API/lifecycle contract are likely culprits. If someone could get the app set up and drop breakpoints in the lifecycle handler, the method that reads the file, and the method that writes the file, it would probably become clear pretty quickly where the breakdown is happening.

dougkeen avatar Oct 31 '23 20:10 dougkeen