Doug Bunting

Results 268 comments of Doug Bunting

Sounds fine though I note we have been using `HelixConstants` less and less lately

All `npm` packages **must** be sourced from the `dotnet-public-npm` feed, at least in our regular CI. I think that means the VMR as well but defer to @mmitche there. @omajid...

> I just realized that `yarn` isn't available in some of the environments that we would want to build ASP.NET Core in, such as RHEL 8. `npm` seems to be...

> The [npm install docs](https://docs.npmjs.com/cli/v8/commands/npm-install) suggest it might be possible: Might be worth a try in your environment then. That is, see if editing the yarn.lock file and `npm ci`...

Removing ILLink sounds like a regression, especially if the SDK doesn't treat references to the SDK in the same way it does missing targeting packs. What's the mid-term story here❔

@wtgodbe this change broke official builds. See for example. Please immediately either revert this change or update the `binlogtosln` tool version we use.

oops, ignore build because it's still using the wrong registry @wtgodbe should we extend `CodeCheck.ps1` to ensure `^resolved "` lines also match `"https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm/npm/registry/`❔ That would avoid checking in broken changes...