Doug Smith

Results 122 comments of Doug Smith

+1 re: the solution for configuring the pod as the owner of the IP allocation, that's quite excellent, great suggestion. Definitely up for this change / refactor. Thanks for the...

Another quick thought on the labels, I have this idea about a "sticky IP address using MAC address" -- so if a workload comes back up with the same mac...

@xagent003 -- this is a superb idea. I love it. Do you mind making a PR with your changes? Otherwise, I'll try to get in the upcoming few weeks.

Any chance you could rebase and see if this is still an issue, thanks!

@xagent003 do you know if the reconciliation control loop covers this one appropriately? It might. If it doesn't, mind rebasing it and we can take another look? Thanks!

Hi @ohamada ! There is a sync between them. All the changes happen in this repo first (this is the "upstream") and then everything goes "downstream" into openshift/whereabouts-cni, and from...

Thanks for the review Miguel. I'm in favor of this PR, these changes make sense. +1 re: log-level configuration, good to go with that in place. Thanks

It's possible that the spike is from teh reconciliation being scheduled: https://github.com/k8snetworkplumbingwg/whereabouts/pull/238

Thanks for bubbling this back up @iaas365-dev -- I lost track. Let me try to get it on my list for next week before the holidays :+1:

@iaas365-dev (and cc: @rootfs ) I think this actually a typo in the given configuration. It uses `route` instead of `routes` (plural!)... this could use better error messaging, possibly. But,...