cslim icon indicating copy to clipboard operation
cslim copied to clipboard

Potential buffer overflow

Open adamblack1 opened this issue 10 years ago • 2 comments

/src/CSlim/SlimList.c char* SlimList_ToString(SlimList* self)

this function continually appends up to an additional 128 characters to buf. If buf already contains 127 characters this will still append more characters to the string.

adamblack1 avatar Nov 14 '14 23:11 adamblack1

Thanks @adamblack1 for your code review. Do you have any interest in submitting a pull request to address these issues? I can work with you on the process if you are interested

dougbradbury avatar Nov 17 '14 19:11 dougbradbury

@dougbradbury thank you for mentioning the idea of a pull request. I have created a pull request (https://github.com/dougbradbury/cslim/pull/17) I look forward to hearing any feedback that you have.

adamblack1 avatar Nov 22 '14 23:11 adamblack1